[virt-tools-list] [virt-manager PATCH] cloudinit: Add cli option root-password-file=/path/to/file.txt

Cole Robinson crobinso at redhat.com
Mon Jul 15 20:27:19 UTC 2019


On 7/15/19 9:33 AM, Athina Plaskasoviti wrote:
> Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti at gmail.com>
> ---
>  tests/cli-test-xml/root-password.txt | 1 +
>  tests/clitest.py                     | 4 +++-
>  virtinst/cli.py                      | 1 +
>  virtinst/install/cloudinit.py        | 7 +++++++
>  4 files changed, 12 insertions(+), 1 deletion(-)
>  create mode 100644 tests/cli-test-xml/root-password.txt
> 
> diff --git a/tests/cli-test-xml/root-password.txt b/tests/cli-test-xml/root-password.txt
> new file mode 100644
> index 00000000..cdf799c6
> --- /dev/null
> +++ b/tests/cli-test-xml/root-password.txt
> @@ -0,0 +1 @@
> +a1b2c3d4
> diff --git a/tests/clitest.py b/tests/clitest.py
> index 1f7730fb..04fe17e8 100644
> --- a/tests/clitest.py
> +++ b/tests/clitest.py
> @@ -91,6 +91,7 @@ test_files = {
>      'COLLIDE': "/dev/default-pool/collidevol1.img",
>      'ADMIN-PASSWORD-FILE': "%s/admin-password.txt" % XMLDIR,
>      'USER-PASSWORD-FILE': "%s/user-password.txt" % XMLDIR,
> +    'ROOT-PASSWORD-FILE': "%s/root-password.txt" % XMLDIR,
>  }

You don't need to add this, you can just reuse the ADMIN-PASSWORD-FILE,
it's not necessary to use a different path

The patch didn't apply cleanly for me either. I just rebased the
cloudinit branch on top of latest master and pushed it. Please
re-checkout the branch and base your changes on top of it and send a v2

Thanks,
Cole




More information about the virt-tools-list mailing list