[virt-tools-list] [virt-manager PATCH] guest: Enable qemu-ga by default on s390x

[Pavel Hrdina]

On Thu, Jun 13, 2019 at 08:48:52AM +0200, Cornelia Huck wrote:
> On Wed, 12 Jun 2019 19:43:47 +0200
> Andrea Bolognani <abologna at redhat.com> wrote:
> 
> > It was disabled with commit 2aca20141ec3 back in 2015, but
> > these days we have it enabled for all other architectures and
> > there doesn't seem to be a good reason for s390x to keep being
> > the outlier.
> > 
> > Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> > ---
> > Connie (CC'd) says she tested qemu-ga on s390x in the past and
> > remembers it working fine, and also promised she would give it
> > another try tomorrow and report back just for extra safety.
> 
> Yes, I just set up it up again and successfully ran guest-info against
> it. Not really an exhaustive test :), but there's nothing special about
> s390x in that regard. (I did more testing last time I set it up and did
> not see any problems.)
> 
> > 
> >  .../cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml  | 4 ++++
> >  tests/cli-test-xml/compare/virt-install-s390x-cdrom.xml       | 4 ++++
> >  tests/cli-test-xml/compare/virt-install-s390x-graphics.xml    | 4 ++++
> >  tests/cli-test-xml/compare/virt-install-s390x-headless.xml    | 4 ++++
> >  virtinst/guest.py                                             | 3 ---
> >  5 files changed, 16 insertions(+), 3 deletions(-)
> 
> FWIW,
> 
> Acked-by: Cornelia Huck <cohuck at redhat.com>

Pushed, thanks.

Sorry for forgetting to add your Acked-by, I'm not used to having
reviews for virt-manager patches :).

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20190613/c02b2257/attachment.sig>