[virt-tools-list] [virt-viewer PATCH 01/14] po: provide custom make rules for po file management

[Christophe Fergeau]

On Tue, Mar 05, 2019 at 10:27:07AM +0000, Daniel P. Berrangé wrote:
> On Tue, Mar 05, 2019 at 11:23:34AM +0100, Christophe Fergeau wrote:
> > On Wed, Feb 20, 2019 at 05:50:52PM +0000, Daniel P. Berrangé wrote:
> > > Historically we have relied on intltool to install a standard
> > > po/Makefile.in.in which has very limited scope for customization.
> > > intltool is deprecated in favour of standard gettextize tools,
> > > but these share the same disadvantages.
> > > 
> > > Writing make rules for po file management is no more difficult
> > > than any other rules libvirt-glib has, so stop using intltool
> > 
> > s/libvirt-glib/virt-viewer
> > 
> > > and don't use gettextize ether.
> > 
> > > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > 
> > > diff --git a/data/Makefile.am b/data/Makefile.am
> > > index 1f6c8bf..0e50f3d 100644
> > > --- a/data/Makefile.am
> > > +++ b/data/Makefile.am
> > > @@ -68,17 +68,17 @@ else #!WIN32
> > >  desktopdir       = $(datadir)/applications
> > >  DESKTOPFILES     = remote-viewer.desktop.in
> > >  desktop_DATA     = $(DESKTOPFILES:.desktop.in=.desktop)
> > > - at INTLTOOL_DESKTOP_RULE@
> > > +%.desktop: %.desktop.in
> > > +	$(AM_V_GEN)$(MSGFMT) --desktop --template $< -d $(top_srcdir)/po -o $@
> > >  
> > > -MIMEFILES = virt-viewer-mime.xml.in
> > >  mimedir = $(datadir)/mime/packages
> > >  mime_DATA = virt-viewer-mime.xml
> > > - at INTLTOOL_XML_RULE@
> > 
> > Why drop translations from the mime file?
> 
> I don't see any other existing mime files translated, and the gettext
> tools don't recognise the file format AFAICT, so I didn't look like
> this was really needed in the first place. 

On my system, grep -l xml:lang /usr/share/mime/packages/* gives a few
hits, including libreoffice, scribus and the main shared-mime-info file.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20190305/c9bdf3dd/attachment.sig>