[virt-tools-list] [virt-manager PATCH 5/8] domcapabilities: get list of CPU models from domcapabilities

Cole Robinson crobinso at redhat.com
Fri Mar 15 18:07:38 UTC 2019


On 3/15/19 12:41 PM, Pavel Hrdina wrote:
> Currently we just call libvirt API which will return all CPU models for
> specific architecture known to libvirt and we offer all of them to users
> in GUI.  Let's switch to domain capabilities where we have more details
> about these CPUs such as whether each model is usable with current QEMU
> binary.  If libvirt can detect the usability we will offer only CPU
> models that QEMU can actually run.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>   virtManager/connection.py   |  3 ---
>   virtManager/details.py      |  2 +-
>   virtinst/capabilities.py    | 25 -------------------------
>   virtinst/domcapabilities.py | 11 +++++++++++
>   virtinst/support.py         |  2 --
>   5 files changed, 12 insertions(+), 31 deletions(-)

This means we won't get CPU model listing in the UI for the test driver 
since it lacks domcapabilities but does implement getCPUModelNames, but 
that's no big loss

- Cole




More information about the virt-tools-list mailing list