[virt-tools-list] [virt-manager PATCH] guest: Add default RNG to s390x guests
Andrea Bolognani
abologna at redhat.com
Thu Mar 21 14:57:24 UTC 2019
As long as it's supported by both QEMU and the guest OS,
there's really no reason not to add it.
Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml | 3 +++
tests/cli-test-xml/compare/virt-install-s390x-cdrom.xml | 3 +++
tests/cli-test-xml/compare/virt-install-s390x-graphics.xml | 3 +++
tests/cli-test-xml/compare/virt-install-s390x-headless.xml | 3 +++
virtinst/guest.py | 1 +
5 files changed, 13 insertions(+)
diff --git a/tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml b/tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml
index 0941003c..7f21c16c 100644
--- a/tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml
+++ b/tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml
@@ -42,6 +42,9 @@
<model type="virtio"/>
</video>
<watchdog model="diag288" action="reset"/>
+ <rng model="virtio">
+ <backend model="random">/dev/urandom</backend>
+ </rng>
<panic model="s390"/>
</devices>
</domain>
diff --git a/tests/cli-test-xml/compare/virt-install-s390x-cdrom.xml b/tests/cli-test-xml/compare/virt-install-s390x-cdrom.xml
index 7b23ed76..11781f3f 100644
--- a/tests/cli-test-xml/compare/virt-install-s390x-cdrom.xml
+++ b/tests/cli-test-xml/compare/virt-install-s390x-cdrom.xml
@@ -37,5 +37,8 @@
<console type="pty">
<target type="sclp"/>
</console>
+ <rng model="virtio">
+ <backend model="random">/dev/urandom</backend>
+ </rng>
</devices>
</domain>
diff --git a/tests/cli-test-xml/compare/virt-install-s390x-graphics.xml b/tests/cli-test-xml/compare/virt-install-s390x-graphics.xml
index 67fe3eec..1ae4f6ce 100644
--- a/tests/cli-test-xml/compare/virt-install-s390x-graphics.xml
+++ b/tests/cli-test-xml/compare/virt-install-s390x-graphics.xml
@@ -35,5 +35,8 @@
<video>
<model type="virtio"/>
</video>
+ <rng model="virtio">
+ <backend model="random">/dev/urandom</backend>
+ </rng>
</devices>
</domain>
diff --git a/tests/cli-test-xml/compare/virt-install-s390x-headless.xml b/tests/cli-test-xml/compare/virt-install-s390x-headless.xml
index ff59345b..b5b280c6 100644
--- a/tests/cli-test-xml/compare/virt-install-s390x-headless.xml
+++ b/tests/cli-test-xml/compare/virt-install-s390x-headless.xml
@@ -29,5 +29,8 @@
<console type="pty">
<target type="sclp"/>
</console>
+ <rng model="virtio">
+ <backend model="random">/dev/urandom</backend>
+ </rng>
</devices>
</domain>
diff --git a/virtinst/guest.py b/virtinst/guest.py
index 9068d8c4..0538ccfd 100644
--- a/virtinst/guest.py
+++ b/virtinst/guest.py
@@ -828,6 +828,7 @@ class Guest(XMLBuilder):
return
if not (self.os.is_x86() or
self.os.is_arm_machvirt() or
+ self.os.is_s390x() or
self.os.is_pseries()):
return
--
2.20.1
More information about the virt-tools-list
mailing list