[virt-tools-list] [virt-install PATCH v2 4/7] urldetect: return osdict.py:OsMedia instead of Libosinfo.Media
Cole Robinson
crobinso at redhat.com
Thu Mar 28 20:39:36 UTC 2019
On 3/22/19 11:23 AM, Fabiano Fidêncio wrote:
> Consequently, let's:
> - rename urldetect::get_osinfo_media() to get_os_media()
> - rename the installertreemedia::_LocationData::osinfo_media to os_media
> - rename unattended::prepare_install_script's media argument to os_media
> - and also rename media to os_media on its internal
> _get_installation_source() method
> - rename osdict::get_install_script's media argument to os_media
>
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
> virtinst/installertreemedia.py | 8 ++++----
> virtinst/osdict.py | 3 ++-
> virtinst/unattended.py | 10 ++++++----
> virtinst/urldetect.py | 8 ++++----
> 4 files changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/virtinst/installertreemedia.py b/virtinst/installertreemedia.py
> index 7c69c3fb..7e97c10a 100644
> --- a/virtinst/installertreemedia.py
> +++ b/virtinst/installertreemedia.py
> @@ -30,10 +30,10 @@ def _is_url(url):
>
>
> class _LocationData(object):
> - def __init__(self, os_variant, kernel_pairs, osinfo_media):
> + def __init__(self, os_variant, kernel_pairs, os_media):
> self.os_variant = os_variant
> self.kernel_pairs = kernel_pairs
> - self.osinfo_media = osinfo_media
> + self.os_media = os_media
>
> self.kernel_url_arg = None
> if self.os_variant:
> @@ -129,7 +129,7 @@ class InstallerTreeMedia(object):
> if store:
> kernel_paths = store.get_kernel_paths()
> os_variant = store.get_osdict_info()
> - osinfo_media = store.get_osinfo_media()
> + os_media = store.get_os_media()
> if has_location_kernel:
> kernel_paths = [
> (self._location_kernel, self._location_initrd)]
There were two other instances in this function of osinfo_media. I fixed
those and the two issues you pointed out, and pushed this series
Thanks,
Cole
More information about the virt-tools-list
mailing list