[virt-tools-list] [virt-viewer][PATCH v2] Introduce bash completion

Fabiano Fidêncio fidencio at redhat.com
Mon May 6 11:41:32 UTC 2019


On Mon, May 6, 2019 at 1:28 PM Michal Privoznik <mprivozn at redhat.com> wrote:
>
> With this change one can get list of domains on the command line:
>
>   $ virt-viewer -c qemu:///system <TAB><TAB>
>   dom1   dom2   ... domN
>
> The list of domains is fetched using virsh, hence the dependency
> on libvirt-client recorded in the spec file. I think it's fair
> to assume that Linux hosts with virt-viewer will have virsh
> available too. If they don't, nothing breaks and no error message
> is printed.
>
> The completer script is inspired by libvirt.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>
> diff to v1:
> - Fixed 'make syntax-check' issue
> - Introduced support for completing domain IDs
> - Introduced --display= completer

Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>
[snip]




More information about the virt-tools-list mailing list