[virt-tools-list] [virt-manager PATCH] cli: Fix --memballoon autodeflate

Athina Plaskasoviti athina.plaskasoviti at gmail.com
Tue May 28 14:20:46 UTC 2019


Fixing commit ebf21998757b863475a57519a830f5c20b0bb978

XML Mapping:

<memballoon model="virtio" autodeflate="on"/>

Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti at gmail.com>
---
 .../compare/virt-install-singleton-config-2.xml           | 8 ++------
 virtinst/devices/memballoon.py                            | 2 +-
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/tests/cli-test-xml/compare/virt-install-singleton-config-2.xml b/tests/cli-test-xml/compare/virt-install-singleton-config-2.xml
index 8f04436a..7e320b91 100644
--- a/tests/cli-test-xml/compare/virt-install-singleton-config-2.xml
+++ b/tests/cli-test-xml/compare/virt-install-singleton-config-2.xml
@@ -187,9 +187,7 @@
       <model type="qxl"/>
     </video>
     <watchdog model="ib700" action="pause"/>
-    <memballoon model="virtio">
-      <autodeflate>on</autodeflate>
-    </memballoon>
+    <memballoon model="virtio" autodeflate="on"/>
     <rng model="virtio">
       <backend model="egd" type="udp">
         <source mode="bind" host="127.0.0.1" service="8000"/>
@@ -401,9 +399,7 @@
       <model type="qxl"/>
     </video>
     <watchdog model="ib700" action="pause"/>
-    <memballoon model="virtio">
-      <autodeflate>on</autodeflate>
-    </memballoon>
+    <memballoon model="virtio" autodeflate="on"/>
     <rng model="virtio">
       <backend model="egd" type="udp">
         <source mode="bind" host="127.0.0.1" service="8000"/>
diff --git a/virtinst/devices/memballoon.py b/virtinst/devices/memballoon.py
index 9a05b344..1d990406 100644
--- a/virtinst/devices/memballoon.py
+++ b/virtinst/devices/memballoon.py
@@ -13,7 +13,7 @@ class DeviceMemballoon(Device):
     XML_NAME = "memballoon"
 
     model = XMLProperty("./@model")
-    autodeflate = XMLProperty("./autodeflate", is_onoff=True)
+    autodeflate = XMLProperty("./@autodeflate", is_onoff=True)
 
 
     ##################
-- 
2.20.1




More information about the virt-tools-list mailing list