[virt-tools-list] [PATCH 3/3] remote-viewer: allow to build with Microsoft Visual Studio

[Francesco Giudici]

On 12/11/19 12:37, Daniel P. Berrangé wrote:
> On Tue, Nov 12, 2019 at 12:29:12PM +0100, Francesco Giudici wrote:
>> In order to meaningfully use the g_io_channel_win32_new_fd() function
>> the C runtime used by GLib is required, which is msvcrt.dll. In current
>> Microsoft compilers it is near impossible to convince it to build code
>> that would use msvcrt.dll. The last Microsoft compiler version that
>> supported using msvcrt.dll as the C runtime was version 6. The GNU
>> compiler and toolchain for Windows, also known as Mingw, fully supports
>> msvcrt.dll.
>> For this reason, drop the SIGINT handler when building with Microsoft
>> Visual Studio.
> 
> IMHO we should explicitly not support the microsoft compilers at
> all. Just mandate use of GCC or CLang, as they are available for
> every OS platform that matters and support a much better feature
> set and would allow us to simplify code by making use of C
> extensions such as "g_autoptr".

Agreed. Fine to drop the patch for me too.
> 
> 
> Regards,
> Daniel
>