[virt-tools-list] [PATCH 0/1] Errors from repeated default pool creation attempts

[Michael Weiser]

Hello,

I'm seeing error messages like this from libvirtd on startup of
virt-manager:

Oct 25 20:14:27 n libvirtd[9003]: operation failed: pool
'default' already exists with uuid 120371e8-1d0f-48e1-8ef3-e9ab22e33d01

virt-manager debug messages and looking at the source lead me to believe
that at the time of trying to determine if the default pool already
exists, virt-manager has not yet learned of all the existing storage
pools because events have not yet been processed. This is with me not
knowing what these events are exactly or any other thing about hacking
virt-manager. I ventured to produce the attached patch anyway which
indeed silences those messages. Find it in separate mail for your
consideration. :)

virt-manager 2.2.1 debug messages without patch:

</capabilities>

[Fri, 25 Oct 2019 21:01:14 virt-manager 181248] DEBUG (storage:157) Attempting to build default pool with target '/home/m/.local/share/libvirt/images'
[Fri, 25 Oct 2019 21:01:14 virt-manager 181248] DEBUG (storage:380) Creating storage pool 'default' with xml:
<pool type="dir">
  <name>default</name>
  <target>
    <path>/home/m/.local/share/libvirt/images</path>
  </target>
</pool>

[Fri, 25 Oct 2019 21:01:14 virt-manager 181248] DEBUG (connection:998) Building default pool failed: Couldn't create default storage pool '/home/m/.local/share/libvirt/images': Could not define storage pool: operation failed: pool 'default' already exists with uuid 120371e8-1d0f-48e1-8ef3-e9ab22e33d01
[Fri, 25 Oct 2019 21:01:14 virt-manager 181248] DEBUG (connection:797) Using domain events
[Fri, 25 Oct 2019 21:01:14 virt-manager 181248] DEBUG (connection:831) Using network events
[Fri, 25 Oct 2019 21:01:14 virt-manager 181248] DEBUG (connection:850) Using storage pool events
[...]
[Fri, 25 Oct 2019 21:01:14 virt-manager 181248] DEBUG (connection:749) storage pool refresh event: pool=default
[...]
[Fri, 25 Oct 2019 21:01:14 virt-manager 181248] DEBUG (connection:1113) pool=default status=Active added

Current master with patch:

</capabilities>

[Fri, 25 Oct 2019 21:08:52 virt-manager 182046] DEBUG (connection:797) Using domain events
[Fri, 25 Oct 2019 21:08:52 virt-manager 182046] DEBUG (connection:831) Using network events
[Fri, 25 Oct 2019 21:08:52 virt-manager 182046] DEBUG (connection:850) Using storage pool events
[Fri, 25 Oct 2019 21:08:52 virt-manager 182046] DEBUG (connection:868) Using node device events
[...]
[Fri, 25 Oct 2019 21:08:52 virt-manager 182046] DEBUG (connection:749) storage pool refresh event: pool=default
[...]
[Fri, 25 Oct 2019 21:08:52 virt-manager 182046] DEBUG (storage:140) Found default pool name=default target=/home/m/.local/share/libvirt/images
[Fri, 25 Oct 2019 21:08:52 virt-manager 182046] DEBUG (connection:533) conn=qemu:///session changed to state=Active

Michael Weiser (1):
  connection: Avoid repeated default pool creation attempts

 virtManager/connection.py | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

-- 
2.23.0