[PATCH] virtinst: use 'host-passthrough' as default 'host' on AArch64

Liang Yan lyan at suse.com
Tue Apr 7 11:47:55 UTC 2020


Thanks for the comment.

On 4/7/20 3:31 AM, Pavel Hrdina wrote:
> On Mon, Apr 06, 2020 at 04:51:29PM -0400, Liang Yan wrote:
>> virt-install already uses 'host-passthrough' as default when no setup
>> for cmline '--cpu'. However, it will still use 'host-model' when comes
>> with '-cpu host'. This will be a problem for aarch64 platfrom as
>> 'host-model' for aarch64 kvm domain on aarch64 host is not supported yet.
> 
> I don't thing this is a good approach.  virt-install supports
> '--cpu host-passthrough' and having '--cpu host' behave differently on
> each architecture seems wrong to me.
> 
virt-install could support "--cpu host-passthrough", it could also
"--cpu host-model" and so on, that is why made me a little bit confused.
So I thought It may be sync with default setup somehow.

> If libvirt errors out correctly in case of '--cpu host' on aarch64 then
> there is nothing else to do.  If libvirt is happy with that
> configuration but it fails in QEMU or elsewhere with non-descriptive
> error message then we can error out in virt-install.
> 
In QEMU, it only supports "-cpu host", so it kindly depends on how
libvirt explains.

Best,
Liang

> Pavel
> 





More information about the virt-tools-list mailing list