[virt-manager PATCH] disk: Support disk io mode io_uring

Cole Robinson crobinso at redhat.com
Thu Apr 30 12:27:52 UTC 2020


On 4/26/20 11:55 PM, Han Han wrote:
> Support the io_uring io mode, introduced since Libvirt v6.3.0.
> 
> Signed-off-by: Han Han <hhan at redhat.com>
> ---
>  man/virt-install.pod     | 2 +-
>  virtinst/devices/disk.py | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man/virt-install.pod b/man/virt-install.pod
> index 12840253..a8fca815 100644
> --- a/man/virt-install.pod
> +++ b/man/virt-install.pod
> @@ -977,7 +977,7 @@ storage. Typically does not need to be set by the user.
>  
>  =item B<driver.io>
>  
> -Disk IO backend. Can be either "threads" or "native".
> +Disk IO backend. Can be either "threads", "native" or "io_uring".
>  
>  =item B<driver.error_policy>
>  
> diff --git a/virtinst/devices/disk.py b/virtinst/devices/disk.py
> index c9db10ad..ee45454f 100644
> --- a/virtinst/devices/disk.py
> +++ b/virtinst/devices/disk.py
> @@ -78,6 +78,7 @@ class DeviceDisk(Device):
>  
>      IO_MODE_NATIVE = "native"
>      IO_MODE_THREADS = "threads"
> +    IO_MODE_IO_URING = "io_uring"
>  
>  
>      @staticmethod
> 

Actually I'd rather remove the IO_MODE constants entirely,
IO_MODE_THREADS is only used in one place so they don't add much. Want
to submit a separate patch for that? The docs change can be its own commit

Thanks,
Cole




More information about the virt-tools-list mailing list