[virt-viewer PATCH] about ui: year 2020 in Copyright

[Daniel P. Berrangé]

On Fri, Aug 28, 2020 at 10:22:49AM -0400, Frediano Ziglio wrote:
> > 
> > On Thu, Aug 27, 2020 at 09:39:37PM +0300, Uri Lublin wrote:
> > > rhbz#1848267
> > > 
> > > Signed-off-by: Uri Lublin <uril at redhat.com>
> > 
> > Patches need to be subitted as pull requests to the gitlab repo
> > please.
> > 
> > > ---
> > > 
> > > Should po/* files be modified too ?
> > 
> > Not really. There's no need to keep changing copyright dates in source
> > files in general.
> > 
> 
> Yes, but the string this patch refers is marked as translatable and it's
> translated in some *.po files. It's not about source file dates.

We should make it non-translatable, as it doesn't make sense to change
copyright statements in translations.

Regardless, po/*.po files must NEVER be touched by any commit.

Only weblate is permitted to touch the po files otherwise we
get conflicts.

The .pot file is periodically refreshed out of band.

> 
> > > 
> > > ---
> > >  src/resources/ui/virt-viewer-about.ui | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/src/resources/ui/virt-viewer-about.ui
> > > b/src/resources/ui/virt-viewer-about.ui
> > > index 681590f..25b2165 100644
> > > --- a/src/resources/ui/virt-viewer-about.ui
> > > +++ b/src/resources/ui/virt-viewer-about.ui
> > > @@ -15,7 +15,7 @@
> > >      <property name="skip_pager_hint">True</property>
> > >      <property name="program_name">Virtual Machine Viewer</property>
> > >      <property name="copyright" translatable="yes">Copyright (C) 2007-2012
> > >      Daniel P. Berrange
> > > -Copyright (C) 2007-2014 Red Hat, Inc.</property>
> > > +Copyright (C) 2007-2020 Red Hat, Inc.</property>
> > >      <property name="comments" translatable="yes">A remote desktop client
> > >      built with GTK-VNC, SPICE-GTK and libvirt</property>
> > >      <property
> > >      name="website">https://gitlab.com/virt-viewer/virt-viewer</property>
> > >      <property
> > >      name="website_label">https://gitlab.com/virt-viewer/virt-viewer</property>
> > > --
> > > 2.26.2
> > > 
> > 
> > Regards,
> > Daniel

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|