[virt-manager RFC PATCH 1/3] Fix check for q35 machine type

Charles Arnold carnold at suse.com
Tue May 5 15:25:09 UTC 2020


This fix could be included independent of the other patches.

---
 virtinst/domain/launch_security.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtinst/domain/launch_security.py b/virtinst/domain/launch_security.py
index 1d8410c1..6eb87add 100644
--- a/virtinst/domain/launch_security.py
+++ b/virtinst/domain/launch_security.py
@@ -30,7 +30,7 @@ class DomainLaunchSecurity(XMLBuilder):
         # exercise for pc-i440fx to make SEV work, AMD recommends Q35 anyway
         # NOTE: at some point both of these platform checks should be put in
         # validate(), once that accepts the 'guest' instance
-        if guest.os.machine != "q35" or guest.os.loader_type != "pflash":
+        if guest.os.is_q35() is False or guest.os.loader_type != "pflash":
             raise RuntimeError(_("SEV launch security requires a Q35 UEFI machine"))
 
         # libvirt or QEMU might not support SEV
-- 
2.26.1





More information about the virt-tools-list mailing list