[virt-manager PATCH] virtinst: fix error message format string

Cole Robinson crobinso at redhat.com
Wed Feb 10 15:30:43 UTC 2021


On 2/10/21 8:54 AM, Roman Bogorodskiy wrote:
> Fix a regression introduced by commit 71f034d6b where
> format string expects kwarg "domain", but "vm" is passed instead.
> 
> Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
> ---
>  virtinst/virtxml.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtinst/virtxml.py b/virtinst/virtxml.py
> index bd2b4282..0c8da37e 100644
> --- a/virtinst/virtxml.py
> +++ b/virtinst/virtxml.py
> @@ -251,7 +251,7 @@ def start_domain_transient(conn, xmlobj, devs, action, confirm):
>          dom = conn.createXML(xmlobj.get_xml())
>      except libvirt.libvirtError as e:
>          fail(_("Failed starting domain '%(domain)s': %(error)s") % {
> -                 "vm": xmlobj.name,
> +                 "domain": xmlobj.name,
>                   "error": e,
>               })
>      else:
> 

Pushed, thanks. Also I pushed a follow up patch to fix the test case
that should have caught this

- Cole




More information about the virt-tools-list mailing list