[PATCH virt-install v1 1/3] virt-install: add mediated device

Cole Robinson crobinso at redhat.com
Tue May 18 22:45:36 UTC 2021


On 4/14/21 11:18 AM, Shalini Chellathurai Saroja wrote:
> Add support to install a virtual server with passed-through mediated
> device. Mediated device can be created using vGPU attached to
> vfio_pci driver or DASD attached to vfio_ccw driver or APQNs attached
> to vfio_ap driver.
> 
> Signed-off-by: Shalini Chellathurai Saroja <shalini at linux.ibm.com>
> ---
>  .../cli/compare/virt-install-many-devices.xml | 19 +++++++++
>  tests/data/testdriver/testdriver.xml          | 40 +++++++++++++++++++
>  tests/test_cli.py                             |  3 ++
>  tests/test_nodedev.py                         | 30 ++++++++++++++
>  virtinst/devices/hostdev.py                   | 34 +++++++++++++++-
>  virtinst/nodedev.py                           |  4 ++
>  6 files changed, 129 insertions(+), 1 deletion(-)

Sorry for the massively delayed review.

This patch looks good. I pushed this patch with a tweak to the
hostdev.py error message.

I'll follow up to the other patches individually

Thanks,
Cole




More information about the virt-tools-list mailing list