Xen dom0 support for virt-what seems broken

[Richard W.M. Jones]

On Tue, Oct 19, 2021 at 03:55:39AM +0200, Daniele Palumbo wrote:
> Hi,
> 
> First, i'm new to this list.
> Therefore, hi everyone once again.
> 
> I was upgrading on a Gentoo server virt-what from 1.18 to 1.21.
> Suddenly, facter reported that 
> is_virtual = true.
> 
> I've tracked this down to:
> v1.18:
> xen-lipi-1 ~ # /usr/libexec/virt-what-cpuid-helper
> 
> xen-lipi-1 ~ # virt-what
> xen
> xen-dom0
> xen-lipi-1 ~ #
> 
> v1.21:
> xen-lipi-4 ~ # /usr/libexec/virt-what-cpuid-helper
> XenVMMXenVMM
> xen-lipi-4 ~ # virt-what
> xen
> xen-hvm
> xen-lipi-4 ~ #
> 
> This seems anyhow to be a change between v1.20 and v1.21 in virt-what-cpuid-helper.c:
> [...]
> +static int
> +known_signature (const char *sig)
> [...
> +    strcmp (sig, "XenVMMXenVMM") == 0 ||
> [...]
> 
> If we go back to virt-what.in:
> [...]
> # Check for Xen.
> 
> if [ "$cpuid" = "XenVMMXenVMM" ] &&
>     ! echo "$dmi" | grep -q 'No SMBIOS nor DMI entry point found, sorry'; then
>     echo xen; echo xen-hvm
>     skip_qemu_kvm=true
> [...]
> 
> Therefore the output will always be 
> """
> xen
> xen-hvm
> """
> 
> Which seems to not contain xen-dom0, so i would say that the problem is in virt-what.
> If i'm wrong, and the problem is in facter, i would happily report a but there.

(I don't read this list regularly, best to CC me ...)

Can you see if virt-what 1.22 still exhibits the bug?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v