[virt-manager] [PATCH 0/2] Add --defaultiothread and iothreadids improvements

[Lin Ma]

Agreed. I'm about to adjust it.

Thanks,
Lin

________________________________________
From: Cole Robinson <crobinso at redhat.com>
Sent: Monday, August 1, 2022 11:45 PM
To: Lin Ma; virt-tools-list at redhat.com
Subject: Re: [virt-manager] [PATCH 0/2] Add --defaultiothread and iothreadids improvements

On 7/29/22 7:16 AM, Lin Ma wrote:
> * Add --defaultiothread
>
> * Add two optional attributes to --iothreads iothreadids:
> --iothreads iothreadids.iothread[0-9]*.thread_pool_min
> --iothreads iothreadids.iothread[0-9]*.thread_pool_max
>
> Lin Ma (2):
>   cli: Add iothreadids attributes thread_pool_min and thread_pool_max
>   cli: Add support for --defaultiothread
>
>  man/virt-install.rst                          | 15 ++++++++++
>  man/virt-xml.rst                              |  1 +
>  .../cli/compare/virt-install-many-devices.xml |  3 +-
>  tests/test_cli.py                             |  5 +++-
>  virtinst/cli.py                               | 29 ++++++++++++++++++-
>  virtinst/guest.py                             | 15 ++++++++--
>  6 files changed, 63 insertions(+), 5 deletions(-)
>

Thanks, I pushed patch #1. Second patch looks okay but I'd prefer to
stuff those options as suboptions of --iothreads, like we do for
iothreadids. So

--iothreads
defaultiothread.thread_pool_min=8,defaultiothread.thread_pool_max=16

This lets us drop the .rst file updates for something that's pretty
advanced/obscure, and keeps the current pattern for handling
/domain/iothreads and /domain/iothreadids. Thoughts?

Thanks,
Cole