[PATCH virt-manager v4] virt-manager: prevent attach of inactive nodedevs

Cole Robinson crobinso at redhat.com
Sat Feb 12 16:28:37 UTC 2022


On 2/11/22 8:33 AM, Shalini Chellathurai Saroja wrote:
> With virt-manager application, it is possible to add inactive node
> devices(eg: mediated device) in host system to guest system. But it is
> impossible to start a guest system with inactive node devices.  Also,
> it is not yet possible to start a node device with virt-manager
> application. So, the user cannot use the inactive node devices.
> 
> This patch disables the "finish" button and provides a tip, when
> inactive node devices are selected. So, it is not possible to add
> inactive node devices to the guest system.
> 
> Signed-off-by: Shalini Chellathurai Saroja <shalini at linux.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>
> ---

Thanks, pushed now. I added some small tweaks on top, to add uitest
coverage, and to move the tooltip from the finish button to the actual
row in treeview. Problem with the finish button is we'd need to audit
other places to make sure the tooltip was removed when switching pages
for example

Thanks,
Cole




More information about the virt-tools-list mailing list