[virt-tools-list] [virt-manager PATCH v2] [RFC] Make deleting storage files default with added prompt

[Daniel P. Berrange]

On Mon, Dec 03, 2012 at 05:12:59PM +0100, Martin Kletzander wrote:
> This patch changes the default checkbox-state of "Delete all
> associated storage" to be checked, but adds a prompt with a warning
> for users to be sure they notice this change and they know what they
> are doing (hopefully).
> ---
> I tried playing with this and it works, but unfortunately after the
> configuration gets changed few times.  I haven't tried on a clean
> machine, so it maybe a problem of some old schemas being stuck in
> there.  Feel free to correct my thoughts and patch.
> 
> v2:
>  - there is no configuration for what the default state should be,
>    it's changed to 'checked' by default, but there is a prompt added
> 
>  src/virt-manager.schemas.in    | 13 +++++++++++++
>  src/virtManager/config.py      |  8 +++++++-
>  src/virtManager/delete.py      | 12 ++++++++++--
>  src/virtManager/preferences.py | 11 ++++++++++-
>  src/vmm-preferences.ui         | 30 ++++++++++++++++++++++++++++++
>  5 files changed, 70 insertions(+), 4 deletions(-)

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|