[virt-tools-list] [virt-manager PATCH v2] [RFC] Make deleting storage files default with added prompt

[Cole Robinson]

On 12/03/2012 03:17 PM, Dave Allan wrote:
> On Mon, Dec 03, 2012 at 05:12:59PM +0100, Martin Kletzander wrote:
>> This patch changes the default checkbox-state of "Delete all
>> associated storage" to be checked, but adds a prompt with a warning
>> for users to be sure they notice this change and they know what they
>> are doing (hopefully).
> 
> I really think that changing the default from preserve user data to
> destroy user data is asking for trouble.
> 

By default we don't offer to delete readonly, sharable, or paths in use by
other VMs on the same connection. Coupled with the new confirmation dialog, I
think things are safe, and IMO is what the target audience of virt manager
likely wants out of a GUI initiated VM delete.

I agree this changes may make it easier for someone to accidentally delete
valuable data, but that requires they either 1) don't read the (adequate)
warnings or 2) misjudge the value of the data they chose to delete.

- Cole