[virt-tools-list] [virt-manager PATCH] virt-install: Add --blkiotune option

Cole Robinson crobinso at redhat.com
Thu Feb 6 13:52:16 UTC 2014


On 02/06/2014 04:40 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> This patch provides the ability to
> tune Blkio cgroup tunable parameters for the domain.
> 

Thanks! Code looks fine, so please push. But can you check add a few
additional things?

- Add a <blkiotune> element to testdriver.xml test-many-devices. You might
need to do python setup.py tests --regenerate-output after this, since it will
likely alter some of the diffs we track as test output.

- Add a couple clitests for virt-xml: --edit compare and --build-xml should
work. You will probably need to tweak cli.py to make --build-xml work.

- Add a --blkiotune example to the many-devices compare test in clitest.py

Thanks,
Cole




More information about the virt-tools-list mailing list