[virt-tools-list] [virt-manager PATCH] virt-install: add "-c" as short option of "--connect"

[Cole Robinson]

On 02/11/2014 09:54 AM, Chen Hanxiao wrote:
> 
> 
> On 02/11/2014 10:26 PM, Cole Robinson wrote:
>> On 02/11/2014 09:22 AM, Chen Hanxiao wrote:
>>>
>>>
>>> On 02/11/2014 09:04 PM, Cole Robinson wrote:
>>>> On 02/11/2014 01:58 AM, Chen Hanxiao wrote:
>>>>> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>>>>>
>>>>> Add "-c" as short option of "--connect".
>>>>> Replace original "-c" as "-cd" for "--cdrom"
>>>>>
>>>>> This will be much convenient if we operate
>>>>> non-default hypervisor.
>>>>>
>>>>> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>>>>> ---
>>>>>    man/virt-install.pod | 2 +-
>>>>>    man/virt-xml.pod     | 2 +-
>>>>>    virt-install         | 7 ++-----
>>>>>    virtinst/cli.py      | 2 +-
>>>>>    4 files changed, 5 insertions(+), 8 deletions(-)
>>>>>
>>>>
>>>> This will break any pre-existing users of virt-install -c <cdrom>, so it's
>>>> not
>>>> acceptable. We could make the -c shortcut available for the other tools, but
>>>> then things would be inconsistent. So I'd rather just leave it the way it is.
>>>>
>>>
>>> How about give --connect a shortcut?
>>> It's not so convenient if using virt-xml editing LXC domain.
>>>
>>
>> We should use any other shortcut besides '-c' because that's what all other
>> libvirt apps use. unfortunately virt-install with its -c shortcut existed
>> before --connect was widespread.
>>
>> I'll retract my objection about adding -c shortcut for virt-xml. But we can't
>> do it for virt-install.
>>
> Sorry for my poor English.
> I mean how about give a shortcut for --connect with another choice and keep
> '-c' as it used to be.
> Can we use same shortcut option but different meanings between virt-install
> and virt-xml?
> 
> 
> 

My english wasn't very clear either :)

I don't think we should use any other shortcut besides '-c' , since apps like
virt-viewer and virsh and virt-df etc, already use -c/--connect, so we
shouldn't deviate from that. My suggestion is to do:

virt-install --connect, -c cdrom
virt-xml -c/--connect

Even though they are different, -c/--connect is the convention so I think it's
okay. We just can't change virt-install. I don't think people will be confused
in practice.

- Cole