[virt-tools-list] [virt-manager PATCH] delete: disable storage removal by default

[Martin Kletzander]

On Mon, Feb 17, 2014 at 01:05:29AM -0500, Chen Hanxiao wrote:
> We should disable storage removal by default
> and let user select it.
>

We chose to default it to True since there is a confirmation needed
anyway.  Look at the commit b2a7c396 (git blame on master on the line
you've changed).

If you really need it not to be selected by default, please make it
configurable.  Although it'll add a lot of unnecessary code :(

Martin

> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  virtManager/delete.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virtManager/delete.py b/virtManager/delete.py
> index 33860bf..96cac58 100644
> --- a/virtManager/delete.py
> +++ b/virtManager/delete.py
> @@ -101,7 +101,7 @@ class vmmDeleteDialog(vmmGObjectUI):
>              self.widget("delete-warn-running-vm-box"), vm_active)
>
>          # Disable storage removal by default
> -        self.widget("delete-remove-storage").set_active(True)
> +        self.widget("delete-remove-storage").set_active(False)
>          self.widget("delete-remove-storage").toggled()
>
>          populate_storage_list(self.widget("delete-storage-list"),
> --
> 1.8.5.3
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140217/1a638f69/attachment.sig>