[virt-tools-list] [PATCH virt-viewer] spice: ask credentials for proxy

[Daniel P. Berrange]

On Mon, Feb 24, 2014 at 03:11:52PM +0100, Marc-André Lureau wrote:
> On Mon, Feb 24, 2014 at 12:43 PM, Daniel P. Berrange
> <berrange at redhat.com> wrote:
> > On Mon, Feb 24, 2014 at 06:39:48AM -0500, Marc-André Lureau wrote:
> >>
> >>
> >> ----- Original Message -----
> >> > On Mon, Feb 24, 2014 at 09:36:15AM +0100, Christophe Fergeau wrote:
> >> > > On Fri, Feb 21, 2014 at 01:02:25PM +0100, Marc-André Lureau wrote:
> >> > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >> > > >
> >> > > > If Spice proxy requires authentication, ask credentials and try
> >> > > > connecting again.
> >> > > > ---
> >> > > >  configure.ac                    |  3 +--
> >> > > >  src/virt-viewer-session-spice.c | 38
> >> > > >  +++++++++++++++++++++++++++++++-------
> >> > > >  2 files changed, 32 insertions(+), 9 deletions(-)
> >> > > >
> >> > > > diff --git a/configure.ac b/configure.ac
> >> > > > index 7a00bf4..5ee49fb 100644
> >> > > > --- a/configure.ac
> >> > > > +++ b/configure.ac
> >> > > > @@ -1,4 +1,3 @@
> >> > > > -
> >> > > >  AC_INIT([virt-viewer],[0.6.0])
> >> > > >  AC_CONFIG_SRCDIR(src/virt-viewer-main.c)
> >> > > >  AC_CONFIG_MACRO_DIR([m4])
> >> > > > @@ -19,7 +18,7 @@ GTK2_REQUIRED="2.18.0"
> >> > > >  GTK3_REQUIRED="3.0"
> >> > > >  GTK_VNC1_REQUIRED="0.3.8"
> >> > > >  GTK_VNC2_REQUIRED="0.4.0"
> >> > > > -SPICE_GTK_REQUIRED="0.22"
> >> > > > +SPICE_GTK_REQUIRED="0.23.21"
> >> > >
> >> > > ACK, though I'm not sure we want to have virt-viewer depend on spice-gtk
> >> > > git. Probably better to wait until next spice-gtk release before pushing
> >> > > this?
> >> >
> >> > NACK to this change. The virt-viewer GIT codebase must *always* build
> >> > against the latest stable Fedora releases. F20 only has 0.22, so this
> >> > change must not be made unless F20 gets a newer spice-gtk release in
> >> > its stable updates repo.
> >> >
> >>
> >> This is either asking for latest spice-gtk in f20, which can be a
> >> bit risky, or waiting for a few cycles. Is this really the way to
> >> handle development of such tight projects?
> >
> > Yes, I think it is important that the code is able to build on the
> > current stable release of Fedora. All the formal releases including
> > the windows binary packages are created using whatever the current
> > stable release is at the time of release.
> 
> I know it's a bit silly to say that, but spice-gtk is an optionnal dep anyway.
> 
> > A third way is to make the code conditional on existance of the newer
> > version using a equiv of GTK_CHECK_VERSION() for spice-gtk version
> > checks
> 
> I sent a patch to add this. I guess I can backport it to f20.

No need to backport it - just do this

 #if defined(SPICE_GTK_CHECK_VERSION) && SPICE_GTK_CHECK_VERSION(....)

it'll go away again in 6months or so when F21 becomes stable release and
we can update the min dep.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|