[virt-tools-list] [virt-manager PATCH] cli: add missing remove_first method for --blkiotune

Chen Hanxiao chenhanxiao at cn.fujitsu.com
Wed Feb 26 01:38:06 UTC 2014



> -----Original Message-----
> From: Cole Robinson [mailto:crobinso at redhat.com]
> Sent: Tuesday, February 25, 2014 9:36 PM
> To: Chen Hanxiao; virt-tools-list at redhat.com
> Subject: Re: [virt-tools-list] [virt-manager PATCH] cli: add missing
remove_first
> method for --blkiotune
> 
> On 02/25/2014 01:47 AM, Chen Hanxiao wrote:
> > Add missing remove_first method for --blkiotune.
> > Update related man pages.
> >
> > Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> >
> > -    --blkiotune weight=100
> > +    --blkiotune 100
> >      --blkiotune weight=100,device_path=/dev/sdc,device_weight=200
> >
> >  Use --blkiotune=? to see a list of all available sub options. Complete
details at
> L<http://libvirt.org/formatdomain.html#elementsBlockTuning>
> > diff --git a/virtinst/cli.py b/virtinst/cli.py
> > index 5bdc1de..826663a 100644
> > --- a/virtinst/cli.py
> > +++ b/virtinst/cli.py
> > @@ -2026,6 +2026,7 @@ class ParserPanic(VirtCLIParser):
> >  class ParserBlkiotune(VirtCLIParser):
> >      def _init_params(self):
> >          self.clear_attr = "blkiotune"
> > +        self.remove_first = "weight"
> >
> >          self.set_param("blkiotune.weight", "weight")
> >          self.set_param("blkiotune.device_path", "device_path")
> >
> 
> ACK
> 
> - Cole

Thanks, pushed.





More information about the virt-tools-list mailing list