[virt-tools-list] [virt-viewer] Fix check of virt_viewer_app_initial_connect return value

Christophe Fergeau cfergeau at redhat.com
Thu Nov 13 10:19:48 UTC 2014


Commit 13f493200 changed virt_viewer_app_initial_connect to return a
gboolean rather than an int, but one call site was not updated to the
new convention, and was still checking for a negative value rather than
for FALSE in order to detect failures.
---
 src/virt-viewer-app.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index 262d75e..88db463 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -1331,7 +1331,7 @@ virt_viewer_app_connect_timer(void *opaque)
     g_debug("Connect timer fired");
 
     if (!priv->active &&
-        virt_viewer_app_initial_connect(self, NULL) < 0)
+        !virt_viewer_app_initial_connect(self, NULL))
         gtk_main_quit();
 
     if (priv->active) {
-- 
2.1.0




More information about the virt-tools-list mailing list