[virt-tools-list] [virt-viewer] Fix check of virt_viewer_app_initial_connect return value

Fabiano Fidêncio fabiano at fidencio.org
Thu Nov 13 12:40:54 UTC 2014


On Thu, Nov 13, 2014 at 11:19 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> Commit 13f493200 changed virt_viewer_app_initial_connect to return a
> gboolean rather than an int, but one call site was not updated to the
> new convention, and was still checking for a negative value rather than
> for FALSE in order to detect failures.
> ---
>  src/virt-viewer-app.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index 262d75e..88db463 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -1331,7 +1331,7 @@ virt_viewer_app_connect_timer(void *opaque)
>      g_debug("Connect timer fired");
>
>      if (!priv->active &&
> -        virt_viewer_app_initial_connect(self, NULL) < 0)
> +        !virt_viewer_app_initial_connect(self, NULL))
>          gtk_main_quit();
>
>      if (priv->active) {
> --
> 2.1.0
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list


ACK!
-- 
Fabiano Fidêncio




More information about the virt-tools-list mailing list