[virt-tools-list] Virt-Viewer Bug: Not Reading In And Using VM Title

[Ben Mathews]

 If I understand the implementation correctly, I believe that virt-viewer should display the Title of the VM in the titlebar if the Title has been set for that particular VM on the server.  See the logic in virt_viewer_app_get_title in virt-viewer-app.c (https://pagure.io/virt-viewer/blob/master/f/src/virt-viewer-app.c#_711), where it first tries to access the title, and if that's null it tries to access the guest_name, and if that's null it uses the guri.  However, the title never gets set when connecting (https://pagure.io/virt-viewer/blob/master/f/src/virt-viewer.c#_869), so the logic falls through to the VM name, not the title.  Is my understanding correct, and does this behavior represent a bug?

If so, I have implemented and tested a simple fix on Ubuntu 18.04, and can report and fix via Ubuntu.  I would also be happy to verify that this fix works on the current master branch of the upstream source, and submit a patch to the virt-manager.org team as well.

Please advise on how I should proceed.

Thanks for the great software!

Ben Mathews
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20180917/250ebaeb/attachment.htm>