[virt-tools-list] Virt-Viewer Bug: Not Reading In And Using VM Title

[Christophe Fergeau]

Hey,

On Mon, Sep 17, 2018 at 01:19:55AM +0000, Ben Mathews wrote:
>  If I understand the implementation correctly, I believe that
>  virt-viewer should display the Title of the VM in the titlebar if the
>  Title has been set for that particular VM on the server.  See the
>  logic in virt_viewer_app_get_title in virt-viewer-app.c
>  (https://pagure.io/virt-viewer/blob/master/f/src/virt-viewer-app.c#_711),
>  where it first tries to access the title, and if that's null it tries
>  to access the guest_name, and if that's null it uses the guri. 
>  However, the title never gets set when connecting
>  (https://pagure.io/virt-viewer/blob/master/f/src/virt-viewer.c#_869),
>  so the logic falls through to the VM name, not the title.  Is my
>  understanding correct, and does this behavior represent a bug?
> 
> If so, I have implemented and tested a simple fix on Ubuntu 18.04, and
> can report and fix via Ubuntu.  I would also be happy to verify that
> this fix works on the current master branch of the upstream source,
> and submit a patch to the virt-manager.org team as well.

Yes, if a title is set in libvirt xml, I think it would make sense to
use it in virt-viewer :) Feel free to send a patch against git master to
the mailing list, this is where the reviews are done. Let me know if you
need more details about the correct steps.

Thanks,

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20180921/61a4f42c/attachment.sig>