[virt-tools-list] [virt-install PATCH] osdict: Fix OsMedia::requires_internet() logic
Cole Robinson
crobinso at redhat.com
Mon Apr 1 20:49:46 UTC 2019
On 3/29/19 10:05 AM, Fabiano Fidêncio wrote:
> In case there's no self.osinfo_media, it means the installation won't
> happen from the media itself, so it should return "True" (as in, it
> requires internet).
>
> Returning "False", though, should be done when no "netinst" variant was
> found (but we do have a media).
>
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
> virtinst/osdict.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/virtinst/osdict.py b/virtinst/osdict.py
> index 0c45c522..54286faf 100644
> --- a/virtinst/osdict.py
> +++ b/virtinst/osdict.py
> @@ -638,4 +638,5 @@ class OsMedia(object):
> for variant in variants:
> if "netinst" in variant.get_id():
> return True
> - return False
> + return False
> + return True
>
Thanks, pushed now
- Cole
More information about the virt-tools-list
mailing list