[virt-tools-list] [virt-manager PATCH 2/3] inspection: switch to g.inspect_list_applications2

Pino Toscano ptoscano at redhat.com
Thu Apr 18 14:08:31 UTC 2019


Use the non-deprecated g.inspect_list_applications2() call to list the
installed applications.  It is available since libguestfs >= 1.20, which
is lower than the current requirement (i.e. 1.22).
---
 virtManager/inspection.py | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/virtManager/inspection.py b/virtManager/inspection.py
index a682dea9..09e6ce43 100644
--- a/virtManager/inspection.py
+++ b/virtManager/inspection.py
@@ -264,25 +264,25 @@ class vmmInspection(vmmGObject):
 
             # Inspection applications.
             try:
-                gapps = g.inspect_list_applications(root)
+                gapps = g.inspect_list_applications2(root)
                 # applications listing worked, so make apps a real list
                 # (instead of None)
                 apps = []
                 for gapp in gapps:
                     app = vmmInspectionApplication()
-                    if gapp["app_name"]:
-                        app.name = gapp["app_name"]
-                    if gapp["app_display_name"]:
-                        app.display_name = gapp["app_display_name"]
-                    app.epoch = gapp["app_epoch"]
-                    if gapp["app_version"]:
-                        app.version = gapp["app_version"]
-                    if gapp["app_release"]:
-                        app.release = gapp["app_release"]
-                    if gapp["app_summary"]:
-                        app.summary = gapp["app_summary"]
-                    if gapp["app_description"]:
-                        app.description = gapp["app_description"]
+                    if gapp["app2_name"]:
+                        app.name = gapp["app2_name"]
+                    if gapp["app2_display_name"]:
+                        app.display_name = gapp["app2_display_name"]
+                    app.epoch = gapp["app2_epoch"]
+                    if gapp["app2_version"]:
+                        app.version = gapp["app2_version"]
+                    if gapp["app2_release"]:
+                        app.release = gapp["app2_release"]
+                    if gapp["app2_summary"]:
+                        app.summary = gapp["app2_summary"]
+                    if gapp["app2_description"]:
+                        app.description = gapp["app2_description"]
                     apps.append(app)
             except Exception:
                 logging.exception("%s: exception while listing apps (ignored)",
-- 
2.20.1




More information about the virt-tools-list mailing list