[virt-tools-list] [virt-manager PATCH] installertreemedia, unattended: Only use kernel args from libosinfo

[Pavel Hrdina]

On Thu, Apr 25, 2019 at 03:42:36PM +0200, Fabiano Fidêncio wrote:
> When performing a tree based unattended installation, some distros
> require extra arguments to be passed to the kernel command line.
> 
> Although those extra arguments are handled by
> _OsVariant::get_kernel_url_arg(), it's libosinfo responsability to
> properly inform them to the management apps.
> 
> With that in mind and knowing that osinfo-db has been updated
> accordingly, we can fully rely on the command line returned by libosinfo
> and stop appending arguments returned by get_kernel_url_arg() when
> performing unattended installations.

What happens if there is osinfo-db version installed that supports
unattended installation but the cmdline is still broken?

Pavel

> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
> osinfo-db patches, still not reviewed:
> https://www.redhat.com/archives/libosinfo/2019-April/msg00188.html
> ---
>  virtinst/installertreemedia.py | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/virtinst/installertreemedia.py b/virtinst/installertreemedia.py
> index ea522904..acd1346e 100644
> --- a/virtinst/installertreemedia.py
> +++ b/virtinst/installertreemedia.py
> @@ -198,11 +198,10 @@ class InstallerTreeMedia(object):
>  
>          k, i, a = self._prepare_kernel_url(guest, fetcher)
>  
> -        # If a cmdline was set due to unattended installation, prepend the
> -        # unattended kernel cmdline to the args returned by
> -        # _prepare_kernel_url()
> +        # If a cmdline was set due to unattended installation, let's use it
> +        # instead of relying in the args returned by _prepare_kernel_url()
>          if cmdline:
> -            a = "%s %s" % (cmdline, a)
> +            a = cmdline
>  
>          return k, i, a
>  
> -- 
> 2.21.0
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20190429/d8b8fb45/attachment.sig>